TEMP with initial value and provide default types for shader functions #2318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors shader code to use inline TEMP initialization with initial values, aiming to make the shader code more readable and easier to write. Key changes include:
- Replacing separate TEMP declarations and SET calls with inline initialization.
- Updating variable naming to a lower-case style in shader fragments.
- Adding explicit type information to math function calls in the shader DSL.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| korge/src/korlibs/korge/view/filter/DitheringFilter.kt | Updated index initialization and shader variable naming. |
| korge/src/korlibs/korge/view/fast/FSprites.kt | Adjusted baseSize computation and refined TEMP initialization for trigonometric values. |
| korge/src/korlibs/korge/render/RenderContext2DExt.kt | Replaced SET calls with inline TEMP initialization for shader variables. |
| korge-core/src/korlibs/korge/render/SDFShaders.kt | Inlined TEMP initializations in SDF functions for clarity. |
| korge-core/src/korlibs/graphics/shader/shaders.kt | Updated math functions and introduced a new TEMP overload with explicit type information. |
Comments suppressed due to low confidence (3)
korge/src/korlibs/korge/view/filter/DitheringFilter.kt:41
- Using inline initialization via TEMP improves clarity; please verify that the order of evaluation remains consistent with previous behavior.
val index = TEMP(float(x + y * width.lit))
korge-core/src/korlibs/graphics/shader/shaders.kt:493
- Providing explicit type information in math functions like sin, cos, and tan enhances type safety; please confirm that all downstream usages align with this update.
fun sin(angle: Operand): Operand = Func("sin", angle, type = angle.type)
korge-core/src/korlibs/graphics/shader/shaders.kt:769
- The new TEMP overload for inline initialization improves code readability; please verify its consistent adoption throughout the shader code.
fun TEMP(initialValue: Operand): Temp {
soywiz
reviewed
May 5, 2025
| fun atan(y_over_x: Operand): Operand = Func("atan", y_over_x) | ||
| fun asin(x: Operand): Operand = Func("asin", x, type = x.type) | ||
| fun acos(x: Operand): Operand = Func("acos", x, type = x.type) | ||
| fun atan(yOverX: Operand): Operand = Func("atan", yOverX) |
soywiz
approved these changes
May 5, 2025
Contributor
soywiz
left a comment
soywiz
left a comment
There was a problem hiding this comment.
LGTM. But likely atan is missing the type = as the other functions
reosfire
force-pushed
the
temp-with-initial-value
branch
from
2c7acdb to
48ab7bc
Compare
soywiz
changed the title
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems for me like this change should make shaders more readable and easier to write